Use correct classed error for "same name, different user" case #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevenolen Would you be up for installing this PR and trying again the code that you had trouble with? You can install with This PR should fix the situation where you, for example, write your own pin named "steve.nolen/test". You will still see an error if you try to write a pin named "test"; I think we want to keep that an error for now. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #807
When a user was trying to write a new pin that had the same name as an existing pin belonging to a different user, we weren't correctly adding
class = "pins_pin_missing"to get the right behavior in thetryCatch():pins-r/R/board_connect.R
Lines 276 to 278 in ed3ac3b
This PR adds the correct classed condition.